Revert #3134 - remove anchored clock #3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/easycla |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3359 +/- ##
==========================================
- Coverage 93.16% 92.62% -0.54%
==========================================
Files 229 131 -98
Lines 6658 3201 -3457
Branches 1385 676 -709
==========================================
- Hits 6203 2965 -3238
+ Misses 455 236 -219
|
MSNev
approved these changes
Oct 25, 2022
Flarna
approved these changes
Oct 26, 2022
legendecas
approved these changes
Oct 28, 2022
|
I considered removing it anyway. Span constructor is not meant to be called directly. But since it isn't causing harm it's fine I think |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #3134
The change in question used an "anchored clock" to protect against drift between the performance timing API in the browser and the real time from the system clock. Unfortunately it also caused a problem where the times reported by browser instrumentations had invalid durations because the end times were provided manually from the performance timing API.