feat(instrumentation-grpc): set net.peer.name and net.peer.port on client spans

[ty-elastic]

Which problem is this PR solving?

Set net.peer.name and net.peer.port span attribute on gRPC client spans as a hint to APMs to look for service dependencies. This is a requirement of OTEL gRPC span conventions.

Fixes #3429

Short description of the changes

• decode grpc destination URI (typically dns:host:port)
• set as net.peer.name and net.peer.port

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

• verified net.peer.name and net.peer.port exists as a span attribute in grpc client spans using otel collector
• passes unit tests

Checklist:

• Followed the style guidelines of this project
• Unit tests have been added

[vmarchaud]

could you add a test for this ?

[ty-elastic]

@vmarchaud, absolutely! unit tests added.

[codecov]

Codecov Report

Merging #3430 (dd37c6e) into main (285f282) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3430      +/-   ##
==========================================
+ Coverage   93.75%   93.77%   +0.02%     
==========================================
  Files         248      248              
  Lines        7552     7561       +9     
  Branches     1576     1578       +2     
==========================================
+ Hits         7080     7090      +10     
+ Misses        472      471       -1     

Impacted Files	Coverage Δ
...elemetry-instrumentation-grpc/src/grpc-js/index.ts	92.30% <100.00%> (+0.27%)	⬆️
...entelemetry-instrumentation-grpc/src/grpc/index.ts	93.98% <100.00%> (+0.18%)	⬆️
...es/opentelemetry-instrumentation-grpc/src/utils.ts	94.23% <100.00%> (+0.11%)	⬆️
...-trace-base/src/platform/node/RandomIdGenerator.ts	93.75% <0.00%> (+6.25%)	⬆️

[ty-elastic]

added CHANGELOG addition, fixed lint error

[legendecas]

The specification defines that peer.service:

SHOULD be equal to the actual service.name resource attribute of the remote service if any.

Channel#getTarget returns the address that this client is connected to, rather than the desired service.name.

[ty-elastic]

haha - I agree! I was looking at values in flight from some service which happen to set it to host:port. I'll adjust. Thank you for the reference.

[ty-elastic]

Lemme see how other auto-instrumentation frameworks set this.

[ty-elastic]

@legendecas - ok, I've change this to set net.peer.name and net.peer.port per OTEL RPC conventions.

Per this, we always set net.peer.name regardless of whether is a DNS name or IP: "Sometimes host name is only available to instrumentation as a string which may contain DNS name or IP address. net.peer.name SHOULD be set to the available known hostname (e.g., "127.0.0.1" if connecting to an URL https://127.0.0.1.com/foo)."

[vmarchaud]

@ty-elastic Could you rebase and fix conflicts please ?

[ty-elastic]

@vmarchaud, rebased, conflicts resolved. thx!

[legendecas]

Thank you for working on this!

To fix the linter complaints, you can run npm run lint:fix in experimental/packages/opentelemetry-instrumentation-grpc.

[ty-elastic]

@legendecas , my pleasure! linted... thanks!