Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enforce format with prettier #3444

Merged
merged 4 commits into from
Dec 1, 2022

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Nov 28, 2022

Which problem is this PR solving?

Per https://typescript-eslint.io/docs/linting/troubleshooting/formatting and https://eslint.org/blog/2020/05/changes-to-rules-policies/#what-are-the-changes:~:text=Stylistic%20rules%20are%20frozen, in order to enforce proper formatting with the typescript source files, we should move away from eslint and apply prettier as the formatter.

This can alleviate the review burden on the formatting. Prettier has been integrated into the eslint as part of the eslint-plugin-prettier, so no development flow has been changed: npm run lint:fix will handle all the formatting.

This PR contains two commits:

Type of change

  • Internal development changes.

Checklist:

  • Followed the style guidelines of this project

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #3444 (242b569) into main (b152497) will increase coverage by 0.05%.
The diff coverage is 95.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3444      +/-   ##
==========================================
+ Coverage   93.32%   93.37%   +0.05%     
==========================================
  Files         248      248              
  Lines        7397     7547     +150     
  Branches     1520     1574      +54     
==========================================
+ Hits         6903     7047     +144     
- Misses        494      500       +6     
Impacted Files Coverage Δ
api/src/diag/types.ts 100.00% <ø> (ø)
api/src/metrics/Metric.ts 100.00% <ø> (ø)
api/src/trace/internal/utils.ts 100.00% <ø> (ø)
...ckages/opentelemetry-browser-detector/src/types.ts 100.00% <ø> (ø)
...-instrumentation-grpc/src/enums/AttributeValues.ts 100.00% <ø> (ø)
...entelemetry-instrumentation/src/instrumentation.ts 80.00% <ø> (ø)
...atform/node/instrumentationNodeModuleDefinition.ts 14.28% <ø> (ø)
...src/platform/node/instrumentationNodeModuleFile.ts 100.00% <ø> (ø)
...ter-base/src/platform/node/OTLPExporterNodeBase.ts 50.00% <ø> (ø)
...ntal/packages/otlp-grpc-exporter-base/src/types.ts 100.00% <ø> (ø)
... and 128 more

@legendecas legendecas marked this pull request as ready for review November 28, 2022 08:09
@legendecas legendecas requested a review from a team as a code owner November 28, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants