Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include TraceState in trace exports #3569

Merged
merged 4 commits into from
Jan 27, 2023

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Jan 26, 2023

fix: include TraceState in trace exports

Short description of the changes

Include TraceState in OTEL spans and links.
Print span.traceState in ConsoleSpanExporter.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • adapted tests createExportTraceServiceRequest, should export information about span

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added/updated

Include TraceState in OTEL spans and links.
Print span.traceState in ConsoleSpanExporter.
@Flarna Flarna requested a review from a team as a code owner January 26, 2023 22:15
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #3569 (11553c5) into main (3bc93a9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 11553c5 differs from pull request most recent head 9f44b62. Consider uploading reports for the commit 9f44b62 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3569   +/-   ##
=======================================
  Coverage   93.87%   93.87%           
=======================================
  Files         255      255           
  Lines        7754     7757    +3     
  Branches     1609     1612    +3     
=======================================
+ Hits         7279     7282    +3     
  Misses        475      475           
Impacted Files Coverage Δ
...al/packages/otlp-transformer/src/trace/internal.ts 96.55% <100.00%> (+0.25%) ⬆️
...y-sdk-trace-base/src/export/ConsoleSpanExporter.ts 80.00% <100.00%> (+1.42%) ⬆️

CHANGELOG.md Outdated Show resolved Hide resolved
experimental/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Not sure how this was missed

@dyladan dyladan merged commit 5b070b8 into open-telemetry:main Jan 27, 2023
@Flarna Flarna deleted the export-tracestate branch January 27, 2023 19:02
@dyladan dyladan mentioned this pull request Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants