Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark tests workflow #4144

Merged
merged 9 commits into from
Sep 29, 2023

Conversation

martinkuba
Copy link
Contributor

Which problem is this PR solving?

This is a follow-up to adding performance benchmark tests (#4105). In order for benchmark tests to provide value, it is important to track changes in performance over time.

Short description of the changes

This adds a Github workflow that runs all benchmark tests and publishes results to Github pages. This is similar to what the Collector is already doing here.

The PR is in a draft mode until self-hosted runner is available to this repo (the process of adding a self-hosted runner is progress).

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

The workflow has been tested in a fork. Here is a page with charts that it has generated.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #4144 (fecd2b0) into main (52f428a) will decrease coverage by 0.21%.
The diff coverage is n/a.

❗ Current head fecd2b0 differs from pull request most recent head 8102aae. Consider uploading reports for the commit 8102aae to get more accurate results

@@            Coverage Diff             @@
##             main    #4144      +/-   ##
==========================================
- Coverage   92.50%   92.30%   -0.21%     
==========================================
  Files         275      329      +54     
  Lines        7369     9421    +2052     
  Branches     1540     1980     +440     
==========================================
+ Hits         6817     8696    +1879     
- Misses        552      725     +173     

see 78 files with indirect coverage changes

@martinkuba martinkuba marked this pull request as ready for review September 20, 2023 16:02
@martinkuba martinkuba requested a review from a team as a code owner September 20, 2023 16:02
@martinkuba
Copy link
Contributor Author

I have updated the URL path in Github pages, so that the test results will be accessible under
https://open-telemetry.github.io/opentelemetry-js/benchmarks

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this 🙂

@martinkuba
Copy link
Contributor Author

@pichlermarc Thanks for the review. There is potentially one more change that I am wondering about - should we run this on release or on every merge to main? With merge to main, it would be easier to catch regressions. What do you think?

@pichlermarc
Copy link
Member

@pichlermarc Thanks for the review. There is potentially one more change that I am wondering about - should we run this on release or on every merge to main? With merge to main, it would be easier to catch regressions. What do you think?

👍 for running it on main 🙂

@dyladan
Copy link
Member

dyladan commented Sep 28, 2023

We're already using gh-pages for the reference docs. Will this conflict with that?

@martinkuba
Copy link
Contributor Author

We're already using gh-pages for the reference docs. Will this conflict with that?

No, it will not conflict. It's set to put the results in a benchmarks directory, so it will be available at https://open-telemetry.github.io/opentelemetry-js/benchmarks. This directory will contain only two files - HTML file and a JS data file. Here is an example.

@martinkuba martinkuba mentioned this pull request Sep 28, 2023
7 tasks
@pichlermarc pichlermarc merged commit c84698d into open-telemetry:main Sep 29, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants