Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk-metrics): allow instrument names to contain '/' #4155

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Sep 20, 2023

Which problem is this PR solving?

Fixes #4141

Short description of the changes

Allows the / character in metric instrument name validation.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Updated existing test case

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated – N/A

@aabmass aabmass force-pushed the allow-slash-4141 branch 2 times, most recently from cdce171 to 4f570e9 Compare September 20, 2023 14:23
@aabmass aabmass marked this pull request as ready for review September 20, 2023 14:24
@aabmass aabmass requested a review from a team as a code owner September 20, 2023 14:24
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #4155 (9976b38) into main (1a8652a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 9976b38 differs from pull request most recent head 71bc38d. Consider uploading reports for the commit 71bc38d to get more accurate results

@@            Coverage Diff             @@
##             main    #4155      +/-   ##
==========================================
+ Coverage   92.29%   92.30%   +0.01%     
==========================================
  Files         328      328              
  Lines        9385     9385              
  Branches     1993     1993              
==========================================
+ Hits         8662     8663       +1     
+ Misses        723      722       -1     
Files Changed Coverage
packages/sdk-metrics/src/InstrumentDescriptor.ts 100.00%

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 🙂
Edit: failing windows test is unrelated - looks like some server is unavailable/misbehaving - I'll restart the test.

@pichlermarc pichlermarc merged commit f2fc0d8 into open-telemetry:main Sep 21, 2023
17 checks passed
@aabmass aabmass deleted the allow-slash-4141 branch September 21, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow use of "/" in Metrics Instrument Names
3 participants