Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AWS X-Ray Lambda propagator #4554

Merged
merged 31 commits into from May 3, 2024

Conversation

martinkuba
Copy link
Contributor

@martinkuba martinkuba commented Mar 18, 2024

Which problem is this PR solving?

Fixes part of #4494

This is a new propagator based on this AWS Lambda spec.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@martinkuba martinkuba requested a review from a team as a code owner March 18, 2024 17:35
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (2610122) to head (d61116f).
Report is 16 commits behind head on main.

❗ Current head d61116f differs from pull request most recent head 12b1e23. Consider uploading reports for the commit 12b1e23 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4554      +/-   ##
==========================================
+ Coverage   90.77%   92.80%   +2.03%     
==========================================
  Files          90      328     +238     
  Lines        1930     9512    +7582     
  Branches      417     2047    +1630     
==========================================
+ Hits         1752     8828    +7076     
- Misses        178      684     +506     

see 244 files with indirect coverage changes

@martinkuba martinkuba changed the title add AWX X-Ray Lambda propagator add AWS X-Ray Lambda propagator Mar 26, 2024
@pichlermarc
Copy link
Member

@martinkuba we can remove experimental/packages/propagator-aws-xray-lambda/CHANGELOG.md as there's shared changelog in this repo.

martinkuba and others added 9 commits April 2, 2024 13:47
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good 👍

Blocking the PR via Request changes until #4599 or #4603 is merged to avoid introducing a dependency on contrib

…ambdaPropagator.test.ts

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
@pichlermarc pichlermarc dismissed their stale review April 16, 2024 11:52

XRay propagator was merged, no more reasons to block this PR.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments, overall looks good 👍

CHANGELOG.md Outdated Show resolved Hide resolved
@pichlermarc pichlermarc merged commit b518e16 into open-telemetry:main May 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants