add the missing metrics exporter: exporter-metrics-otlp-http #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise metrics won't work
sashaaKr
reviewed
Feb 13, 2024
|
@rapphil please review this PR |
|
I need this too |
martinkuba
reviewed
Feb 29, 2024
| @@ -22,7 +22,8 @@ import { | |||
| import { getEnv } from '@opentelemetry/core'; | |||
| import { AwsLambdaInstrumentationConfig } from '@opentelemetry/instrumentation-aws-lambda'; | |||
| import { OTLPTraceExporter } from '@opentelemetry/exporter-trace-otlp-proto'; | |||
| import { MeterProvider, MeterProviderOptions } from '@opentelemetry/sdk-metrics'; | |||
| import { MeterProvider, MeterProviderOptions, PeriodicExportingMetricReader } from '@opentelemetry/sdk-metrics'; | |||
| import { OTLPMetricExporter } from '@opentelemetry/exporter-metrics-otlp-grpc' | |||
There was a problem hiding this comment.
I think this should be exporter from exporter-metrics-otlp-proto. That's what what is in package.json, and the tracer is using HTTP proto as well.
There was a problem hiding this comment.
what's the differences between the 2 packages?
There was a problem hiding this comment.
Both use protobuf as the data format, but exporter-*-otlp-proto uses HTTP as the protocol.
There was a problem hiding this comment.
@stevemao Do you have any objection to this suggestion?
|
This would be very helpful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise metrics won't work