Add go sample app path in dependabot #1312
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbenson
reviewed
May 11, 2024
| @@ -21,6 +21,7 @@ updates: | |||
| - "/collector/processor/coldstartprocessor" | |||
| - "/collector/processor/decoupleprocessor" | |||
| - "/collector/receiver/telemetryapireceiver" | |||
| - "/go/sample-apps/function" | |||
There was a problem hiding this comment.
I didn't include this initially because I didn't want to be responsible for fixing it if something breaks.
There was a problem hiding this comment.
This line is just for gomod, which only manages Go module dependencies. That directory just has a hundred lines of Go and outside of OTel depends on a handful of AWS SDK packages. So hopefully that means extra notifications will be minimal.
My thinking is that this visibility will be good for maintenance.. and when an update needs more effort than the project can support at the time a maintainer/approver could dismiss dependabot's alert or add a rule to auto-triage it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sample app path in dependabot