Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dependabot config for NodeJS autoinstrumentation #2602

Closed
wants to merge 0 commits into from

Conversation

akselleirv
Copy link
Contributor

Description:

Added Dependabot for bumping NodeJS updates for the autoinstrumentation with grouping on bump type.

Testing:

Tested the config on my fork. Please see PRs there for how it look like:

@akselleirv akselleirv requested a review from a team as a code owner February 3, 2024 11:44
@TylerHelmuth
Copy link
Member

This is really interesting. We've typically only done a release when the nodejs API/SDK has a bump, but I guess there is nothing stopping us from bumping when only the instrumentation has a release.

@pavolloffay pavolloffay added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 9, 2024
@pavolloffay
Copy link
Member

Can any version be independently bumped https://github.com/open-telemetry/opentelemetry-operator/blob/main/autoinstrumentation/nodejs/package.json?

We might also need to change how we are versioning and when we are releasing the node auto-instrumentation https://github.com/open-telemetry/opentelemetry-operator/blob/main/.github/workflows/publish-autoinstrumentation-nodejs.yaml#L29. Right now it is released only if sdk-node is released.

@atsu85
Copy link
Contributor

atsu85 commented Mar 11, 2024

Thanks @akselleirv! I concidered adding dependabot conf myself (because of #2745 to bump @opentelemetry/auto-instrumentations-node), but found your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants