Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Move TargetAllocator CRD to v1alpha1 #2918

Conversation

swiatekm-sumo
Copy link
Contributor

Alternative approach to #2904. Here we keep the shared stuff in v1beta1, similar to how prometheus-operator does it.

@pavolloffay
Copy link
Member

Here we keep the shared stuff in v1beta1, similar to how prometheus-operator does it.

Could you please share a link to the prom operator?

@swiatekm-sumo
Copy link
Contributor Author

swiatekm-sumo commented May 2, 2024

Here we keep the shared stuff in v1beta1, similar to how prometheus-operator does it.

Could you please share a link to the prom operator?

Here's a v1alpha1 CR using a common fields struct from v1:
https://github.com/prometheus-operator/prometheus-operator/blob/5a8ab71c21639f471595088c12f58fc32160c21c/pkg/apis/monitoring/v1alpha1/prometheusagent_types.go#L29-L31

@swiatekm-sumo swiatekm-sumo force-pushed the chore/move-ta-crd-v1alpha1_take2 branch from fe62872 to 189613d Compare May 21, 2024 14:22
@swiatekm-sumo swiatekm-sumo force-pushed the chore/move-ta-crd-v1alpha1_take2 branch from 189613d to 141266e Compare May 22, 2024 10:23
@swiatekm-sumo swiatekm-sumo marked this pull request as ready for review May 22, 2024 11:51
@swiatekm-sumo swiatekm-sumo requested a review from a team as a code owner May 22, 2024 11:51
@swiatekm-sumo swiatekm-sumo merged commit 9aaa6c9 into open-telemetry:main May 22, 2024
33 checks passed
@swiatekm-sumo swiatekm-sumo deleted the chore/move-ta-crd-v1alpha1_take2 branch May 22, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants