Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of PDB for per-node #2932

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jaronoff97
Copy link
Contributor

Description:
Makes it possible to set PDBs for per-node strategy

Link to tracking Issue(s):

resolves #2900

Testing: unit tests added

Documentation: n/a

@jaronoff97 jaronoff97 marked this pull request as ready for review May 7, 2024 18:17
@jaronoff97 jaronoff97 requested a review from a team as a code owner May 7, 2024 18:17
@jaronoff97 jaronoff97 requested a review from a team May 8, 2024 15:39
@diranged
Copy link

diranged commented May 8, 2024

Thanks @jaronoff97 ... I appreciate the change. I still don't actually think there should be controls on whether or not I am allowed to define a PDB, but at least this will help us solve the issue we were running into! :)

@jaronoff97
Copy link
Contributor Author

@diranged you're always able to define a PDB outside what the operator provides :) this is for the user convenience for something within the bounds of what we know will work. I'd be happy to review a follow up / discuss further during our next sig call!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Target Allocator multiple Replicas with per-node allocationStrategy
4 participants