[featuregate] Automatically set GOMEMLIMIT and GOMAXPROCS for collector, target allocator, opamp bridge #2933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
reviewed
May 15, 2024
| component: collector, target allocator, opamp | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Introduces a new feature gate for `operator.golang.flags` to automatically add the environment variables for GOMAXPROCS and GOMEMLIMIT |
There was a problem hiding this comment.
Do we need to put this behind a feature gate?
There was a problem hiding this comment.
i was thinking we would featuregate to roll out slowly so we could test it in case this doesn't have the effect we intend
…or into set-gomemlimit
swiatekm-sumo
approved these changes
May 20, 2024
pavolloffay
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There's been a lot written about the topic, but basically we should always be setting these for any of the go apps we run.
(good article from John Howard, Istio Maintainer)
Link to tracking Issue(s):
Testing: n/a
Documentation: n/a, though I should probably document this somewhere?