New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for collector readinessProbe #2944
Support for collector readinessProbe #2944
Conversation
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
becfbad
to
6f19ccb
Compare
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
I wouldn't add this to |
+1 we should only add this to v1beta1. |
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
Got it! Just one detail to see if I got it right. Deploying alpha won't have a way to configure anything about readiness but it will enable if healthcheck extension is available. In case the user needs to customize it, they will required to update to beta. Right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with one nitpick.
Yes, that's correct. I think it's fine, especially with a change as safe as this. |
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
Thank you all for the review ;-) Looking forward to get this and a few other improvements in the next releases 💪 ;-) |
Description:
This PR introduces a possibility to customize readinessProbe for OpenTelemetryCollector as well as adds the default just like it is done at liveness and collector chart https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/charts/opentelemetry-collector/values.yaml#L397
Link to tracking Issue(s): #2943
readinessProbe
#2943Testing:
Documentation: