Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for collector readinessProbe #2944

Merged

Conversation

janario
Copy link
Contributor

@janario janario commented May 10, 2024

Description:

This PR introduces a possibility to customize readinessProbe for OpenTelemetryCollector as well as adds the default just like it is done at liveness and collector chart https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/charts/opentelemetry-collector/values.yaml#L397

Link to tracking Issue(s): #2943

Testing:

Documentation:

@janario janario requested a review from a team as a code owner May 10, 2024 07:53
Copy link

linux-foundation-easycla bot commented May 10, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

hesamhamdarsi and others added 4 commits May 10, 2024 10:07
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
@janario janario force-pushed the feature/collector-readiness-probe branch from becfbad to 6f19ccb Compare May 10, 2024 08:08
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
@swiatekm-sumo
Copy link
Contributor

swiatekm-sumo commented May 10, 2024

I wouldn't add this to v1alpha1. That version is now deprecated, and we shouldn't add any more features to it. WDYT @pavolloffay @jaronoff97

@jaronoff97
Copy link
Contributor

+1 we should only add this to v1beta1.

Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
@janario
Copy link
Contributor Author

janario commented May 10, 2024

Got it!
Removed from alpha version.

Just one detail to see if I got it right.

Deploying alpha won't have a way to configure anything about readiness but it will enable if healthcheck extension is available.

In case the user needs to customize it, they will required to update to beta.

Right?

Copy link
Contributor

@swiatekm-sumo swiatekm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one nitpick.

apis/v1beta1/collector_webhook.go Outdated Show resolved Hide resolved
@swiatekm-sumo
Copy link
Contributor

Deploying alpha won't have a way to configure anything about readiness but it will enable if healthcheck extension is available.

In case the user needs to customize it, they will required to update to beta.

Right?

Yes, that's correct. I think it's fine, especially with a change as safe as this.

Signed-off-by: Janario Oliveira <janario.oliveira@gmail.com>
@pavolloffay pavolloffay merged commit 3169efd into open-telemetry:main May 13, 2024
33 checks passed
@janario
Copy link
Contributor Author

janario commented May 13, 2024

Thank you all for the review ;-)

Looking forward to get this and a few other improvements in the next releases 💪 ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for OpenTelemetryCollector readinessProbe
5 participants