Keep multiple versions of Collector Config #2946
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -86,6 +87,10 @@ service: | |||
| goodConfig := v1beta1.Config{} | |||
| err := go_yaml.Unmarshal([]byte(goodConfigYaml), &goodConfig) | |||
| require.NoError(t, err) | |||
|
|
|||
| goodConfigHash, _ := manifestutils.GetConfigMapSHA(goodConfig) | |||
| goodConfigHash = goodConfigHash[:8] | |||
There was a problem hiding this comment.
Nice. These tests were always a pain to update because of this.
jaronoff97
reviewed
May 10, 2024
pavolloffay
reviewed
May 13, 2024
matthagenbuch
force-pushed
the
matth.versioned_config
branch
from
62af5bf
to
5787dd6
Compare
jaronoff97
approved these changes
May 20, 2024
|
@swiatekm-sumo @pavolloffay any other thoughts on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
From the issue:
This PR resolves the issue by keeping 1 or more previous versions of the Collector ConfigMap. The ConfigMap name is suffixed with an 8-character hash of the Config object. The full hash is truncated to 8 characters to leave room in the 63-character name limit for the collector name.
The number of config versions to keep can be specified using the new ConfigVersions field on the CRD. The operator will keep the current version +
ConfigVersionsprevious versions. Cleanup of old versions is handled using the reconciliation code path.This solution was preferred to support for externally managed ConfigMaps based on conversations at the SIG meeting. External ConfigMaps would break some functionality of the operator which requires the collector config to be known by the operator.
Link to tracking Issue(s):
Testing:
local manual testing, unit tests, e2e tests
Documentation:
New configuration value on OpenTelemetryCollector CRD for setting the number of versions to keep.