Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add status fields for instrumentation kind #717

Merged
merged 2 commits into from
Feb 21, 2022
Merged

Add status fields for instrumentation kind #717

merged 2 commits into from
Feb 21, 2022

Conversation

frzifus
Copy link
Member

@frzifus frzifus commented Feb 17, 2022 •
edited by pavolloffay

Signed-off-by: Benedikt Bongartz bongartz@klimlive.de

Updates #544

This pr exposes exporter endpoint, sampler argument and type as status properties of instrumentation objects.

@frzifus frzifus requested review from a team as code owners February 17, 2022 10:13
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 17, 2022 •
edited

CLA Signed

The committers are authorized under a signed CLA.

@pavolloffay
Copy link
Member

@frzifus the CLA is not passing.

Could you please paste here output of kubectl get otelinst?

pavolloffay
pavolloffay reviewed Feb 21, 2022
View reviewed changes
apis/v1alpha1/instrumentation_types.go Outdated Show resolved Hide resolved
apis/v1alpha1/instrumentation_types.go Outdated Show resolved Hide resolved
apis/v1alpha1/instrumentation_types.go Outdated Show resolved Hide resolved
@pavolloffay pavolloffay changed the title add status object for instrumentation kind Add status fields for instrumentation kind Feb 21, 2022
@frzifus
expose exporter endpoint, sampler type and argument of instrumentation
71cf481 
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
@frzifus frzifus force-pushed the feat/add_status_object_for_Instrumentation_kind_#544 branch from 920fea0 to 93324b6 Compare February 21, 2022 12:42
frzifus
frzifus commented Feb 21, 2022
View reviewed changes
Copy link
Member Author

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks like this

NAME                   AGE    ENDPOINT                    SAMPLER                    SAMPLER ARG
my-instrumentation-1   4d3h   http://abc-collector:4317   parentbased_traceidratio   0.25

@frzifus frzifus force-pushed the feat/add_status_object_for_Instrumentation_kind_#544 branch from 93324b6 to 883ae65 Compare February 21, 2022 12:47
@frzifus
regenerate otel-instrumentations
e62484d 
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
@frzifus frzifus force-pushed the feat/add_status_object_for_Instrumentation_kind_#544 branch from 883ae65 to e62484d Compare February 21, 2022 13:00
@pavolloffay pavolloffay merged commit 78100be into open-telemetry:main Feb 21, 2022
@frzifus frzifus deleted the feat/add_status_object_for_Instrumentation_kind_#544 branch February 21, 2022 14:32
@frzifus frzifus mentioned this pull request Aug 23, 2022
Closed
6 tasks
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@frzifus
Add status fields for instrumentation kind (open-telemetry#717)
1b2afee 
* expose exporter endpoint, sampler type and argument of instrumentation

Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>

* regenerate otel-instrumentations

Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavolloffay pavolloffay pavolloffay approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9 Aneurysm9 was automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frzifus @pavolloffay