AWS ECS detector: add support for cloud.{account.id,availability_zone,region} #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmanciop
force-pushed
the
aws-ecs-attrs
branch
5 times, most recently
from
c51b13c
to
dbe6382
Compare
mmanciop
force-pushed
the
aws-ecs-attrs
branch
from
4f1dbd2
to
136dac9
Compare
mmanciop
changed the title
|
@Aneurysm9, @mhausenblas maybe you can expedite this PR somehow? Matching ones have already been merged for .NET, Go, Java and PHP months ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the
cloud.account.id,cloud.availability_zone,cloud.regionandcloud.resource_id(see open-telemetry/semantic-conventions#677) resource attributes in the AWS ECS detector when the Metadatav4 endpoint is in use.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
N/A, there is no docs in the AWS SDK extension about which resource attributes are added by which detector.