Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3.12 to tox #3616

Merged
merged 6 commits into from
Jun 7, 2024
Merged

Add 3.12 to tox #3616

merged 6 commits into from
Jun 7, 2024
+49 −24

Conversation

jeremydvoss
Copy link
Contributor

@jeremydvoss jeremydvoss commented Jan 5, 2024 •
edited

Description

Add tox 3.12 support

Does This PR Require a Contrib Repo Change?

open-telemetry/opentelemetry-python-contrib#2572

@jeremydvoss jeremydvoss mentioned this pull request Jan 5, 2024
Open
@jeremydvoss
Copy link
Contributor Author

For 3.11: https://github.com/open-telemetry/opentelemetry-python/pull/2997/files

@xrmx
Copy link
Contributor

xrmx commented Apr 5, 2024

@jeremydvoss this should now work if rebased on main

@ocelotl
Copy link
Contributor

ocelotl commented Apr 19, 2024

Great, rebased ✌️

xrmx
xrmx reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add 3.12 to github workflows too?

@elebiodaslingshot
Copy link

Im desperate for this merge 😭

@ocelotl
Copy link
Contributor

ocelotl commented May 15, 2024

@jeremydvoss I added some missing changes to complete this PR, do you think we can move forward with this PR?

@jeremydvoss jeremydvoss marked this pull request as ready for review May 16, 2024 16:38
@jeremydvoss jeremydvoss requested a review from a team as a code owner May 16, 2024 16:38
@jeremydvoss jeremydvoss mentioned this pull request May 16, 2024
Closed
@jeremydvoss jeremydvoss added PR:please merge This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) labels May 16, 2024
@xrmx
Copy link
Contributor

xrmx commented May 16, 2024

BTW this require a similar PR in contrib before release right?

@ocelotl ocelotl marked this pull request as draft May 17, 2024 15:42
@ocelotl
Copy link
Contributor

ocelotl commented May 17, 2024

MArking it as draft to prevent merging while I look into 3.12 for the contrib repo.

@ocelotl ocelotl mentioned this pull request May 23, 2024
Open
@xrmx xrmx marked this pull request as ready for review June 6, 2024 07:56
@jeremydvoss
Copy link
Contributor Author

Still one test failing. I'll repush and see if it's transient

@jeremydvoss
Copy link
Contributor Author

Rebased and pushed.

@lzchen lzchen merged commit c5b0244 into open-telemetry:main Jun 7, 2024
269 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocelotl ocelotl ocelotl approved these changes

@xrmx xrmx xrmx approved these changes

@lzchen lzchen lzchen approved these changes

Assignees
No one assigned
Labels
PR:please merge This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jeremydvoss @xrmx @ocelotl @elebiodaslingshot @lzchen