log the attribute's key when encoding an attribute fails #3838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@danielhochman you have to sign the CLA for contributing to OpenTelemetry |
emdneto
reviewed
Apr 9, 2024
| ) | ||
| def test_encode_attributes_error_logs_key(self, mock_logger_exception): | ||
| result = _encode_attributes({"a": 1, "bad_key": None, "b": 2}) | ||
| mock_logger_exception.assert_called_once() |
There was a problem hiding this comment.
I think there's no need to mock. What do you think about use assertLogs instead of this? and also assert the len of the log records?
emdneto
reviewed
Apr 9, 2024
| self.assertEqual( | ||
| mock_logger_exception.call_args_list[0].args[1], "bad_key" | ||
| ) | ||
| self.assertTrue( |
There was a problem hiding this comment.
What do you think of assertIsInstance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include the attribute key that failed to encode. Very hard to track down otherwise.
Before
After
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: