New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Jaeger Remote Sampling addition to contrib repo #3852
base: main
Are you sure you want to change the base?
Support for Jaeger Remote Sampling addition to contrib repo #3852
Conversation
12f597f
to
3b9b109
Compare
@@ -413,7 +456,7 @@ class _ParentBasedAlwaysOn(ParentBased): | |||
def __init__(self, _): | |||
super().__init__(ALWAYS_ON) | |||
|
|||
|
|||
# TODO(sconover): Something must be done to allow samplers from the contrib repo to be specified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most immediate issue is what to do about _KNOWN_SAMPLERS
- verification of sampler choice based on this dict excludes the possibility of contrib-repo samplers, I would appreciate advice about what to do about this.
The sampler loading mechanism should be changed to entrypoint based. We already do this for several components. For example, we have exporters that users can configure with
|
Depends on proposed changes to opentelementry python: open-telemetry/opentelemetry-python#3852
@srikanthccv Ok, upon a second look at this, it would appear that the library has the ability to load an arbitrary sampler from an env var, and that this validation is only used if the sampler selection falls back to default, explanation here. So I think there's nothing to do. |
Description
I'm attempting to port the jaeger remote sampling support from the jaeger-client-python project.
Per @srikanthccv 's feedback here, it really makes more sense for the bulk of the port to go into the contrib repo. However there are elements of the core sampler code that need to change to accommodate these contrib samplers.
I'm opening this in draft mode to seek initial feedback+guidance. There's a series of TODO's that raise questions about approach.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
It doesn't require one, but there will be a companion PR that depends on this change.
Checklist: