feat: add basic implementation of asynchronous metrics #1610
Conversation
…o metrics-asynchronous
…o metrics-asynchronous
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
| end | ||
| end | ||
|
|
||
| def create_callback(callbacks) |
There was a problem hiding this comment.
I think create_callback is a bit of left over from some experimentation. We should probably remove it.
| class ObservableCounter < OpenTelemetry::Metrics::Instrument::ObservableCounter | ||
| attr_reader :name, :unit, :description | ||
| # {ObservableCounter} is the SDK implementation of {OpenTelemetry::SDK::Metrics::Instrument::AsynchronousInstrument}. | ||
| # Asynchronous Counter is an asynchronous Instrument which reports non-additive, monotonically increasing value(s) when the instrument is being observed. |
There was a problem hiding this comment.
This comment is a bit confusing. I think it should read
Asynchronous Counter is an asynchronous Instrument which reports monotonically increasing value(s) when the instrument is being observed.
| @@ -125,6 +125,10 @@ def register_synchronous_instrument(instrument) | |||
| end | |||
| end | |||
|
|
|||
| def register_asynchronous_instrument(instrument) | |||
There was a problem hiding this comment.
Do we need both register_asynchronous_instrument and register_synchronous_instrument?
Could we not have just one function
# @api private
def register_instrument(instrument)
...
end
Description
I'd like to make contribution on basic implementation on asynchronous metrics.
Related: #1386, Asynchronous Up Down Counter card, Asynchronous Gauge.
Spec: asynchronous-instrument-api
WIP: