Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the option of using grpcio for gRPC #1534

Merged
merged 1 commit into from Feb 15, 2024

Conversation

djc
Copy link
Contributor

@djc djc commented Feb 15, 2024

Fixes #1524

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@djc djc requested a review from a team as a code owner February 15, 2024 17:24
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (8688e7e) 61.8% compared to head (dad855e) 65.5%.
Report is 12 commits behind head on main.

Files Patch % Lines
opentelemetry-sdk/src/metrics/periodic_reader.rs 92.1% 4 Missing ⚠️
opentelemetry-sdk/src/logs/log_emitter.rs 90.9% 1 Missing ⚠️
opentelemetry/src/logs/noop.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1534     +/-   ##
=======================================
+ Coverage   61.8%   65.5%   +3.6%     
=======================================
  Files        144     140      -4     
  Lines      19810   19569    -241     
=======================================
+ Hits       12256   12824    +568     
+ Misses      7554    6745    -809     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shaun-cox shaun-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Can you add an entry in changelog.md for the opentelemetry-otlp

@djc djc force-pushed the no-grpcio branch 2 times, most recently from 1609032 to 64bc780 Compare February 15, 2024 19:52
@djc
Copy link
Contributor Author

djc commented Feb 15, 2024

Added changelog entries in -proto and -otlp.

@cijothomas cijothomas merged commit cad63b6 into open-telemetry:main Feb 15, 2024
13 checks passed
@djc djc mentioned this pull request Feb 16, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: remove the grpcio gRPC backend
3 participants