Remove env_logger from workspace. #1673
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdost
force-pushed
the
remove-env-logger
branch
from
d0a7796
to
57735d1
Compare
- We don't want to include it in the top level workspace as it interferes with MSRV, and doesn't provide benefit. - For MSRV check we just run check. - Also bump to 0.11 in example. Relates open-telemetry#1546,open-telemetry#1554
hdost
force-pushed
the
remove-env-logger
branch
from
57735d1
to
9ea90ff
Compare
cijothomas
approved these changes
Apr 21, 2024
cijothomas
reviewed
Apr 21, 2024
| @@ -93,9 +93,9 @@ jobs: | |||
| run: ./scripts/patch_dependencies.sh | |||
| - name: Run tests | |||
There was a problem hiding this comment.
the "Run tests" can be renamed to something more apt to reflect the proposed change.
hdost
commented
Apr 21, 2024
| @@ -11,4 +11,4 @@ opentelemetry-jaeger = { path = "../.." } | |||
| opentelemetry_sdk = { path = "../../../opentelemetry-sdk" } | |||
| actix-web = "4.1" | |||
| actix-service = "2" | |||
| env_logger = "0.10.0" | |||
| env_logger = "0.11.0" | |||
There was a problem hiding this comment.
Suggested change
| env_logger = "0.11.0" | |
| env_logger = "0.10.0" |
hdost
commented
Apr 21, 2024
| @@ -93,9 +93,9 @@ jobs: | |||
| run: ./scripts/patch_dependencies.sh | |||
| - name: Run tests | |||
There was a problem hiding this comment.
Suggested change
| - name: Run tests | |
| - name: Check MSRV compatible |
TommyCpp
approved these changes
May 8, 2024
|
Closing as this got covered via other PRs removing jaeger itself! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to include it in the top level workspace as it interferes with MSRV, and doesn't provide benefit.
Also bump to 0.11 in example.
Relates #1546,#1554
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes