Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Metrics tests and add more #1737

Merged

Conversation

cijothomas
Copy link
Member

Trying to leverage helper methods as much as possible. Not fully done, but moving in that direction.
Added UpDownCounter tests.

@cijothomas cijothomas requested a review from a team as a code owner May 11, 2024 00:19
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 88.95706% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 71.5%. Comparing base (348ec9e) to head (ef23883).
Report is 17 commits behind head on main.

Files Patch % Lines
opentelemetry-sdk/src/metrics/mod.rs 88.9% 18 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1737     +/-   ##
=======================================
+ Coverage   71.0%   71.5%   +0.5%     
=======================================
  Files        135     136      +1     
  Lines      20751   20821     +70     
=======================================
+ Hits       14746   14906    +160     
+ Misses      6005    5915     -90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit bf20372 into open-telemetry:main May 12, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants