Refactor general instrument characteristics; add optional multi-instrument callback support #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ication into jmacd/dup_instruments
…ication into jmacd/dup_instruments
…ication into jmacd/dup_instruments
Co-authored-by: Marc Pichler <marcpi@edu.aau.at>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…ication into jmacd/dup_instruments
…lemetry-specification into jmacd/less_prob_sample_test
…ication into jmacd/dup_instruments
…ication into jmacd/dup_instruments
Co-authored-by: Marc Pichler <marcpi@edu.aau.at>
…ication into jmacd/dup_instruments
…y-specification into jmacd/dup_instruments
Co-authored-by: Aaron Abbott <aaronabbott@google.com>
Co-authored-by: Aaron Abbott <aaronabbott@google.com>
Co-authored-by: Aaron Abbott <aaronabbott@google.com>
…ication into jmacd/dup_instruments
…ication into jmacd/multi_inst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2280
Part of #2350
Changes
This PR is written to be applied after #2317. To read the diff between this PR and that PR, see this link.
There is a standing feature request to support async callbacks with multiple instruments. This introduces that option in the general characteristics section that applies to all asynchronous instruments. These sections were not headers in the TOC, so I made them into sections to clarify the document structure. General properties that had been duplicated for every instrument are now consolidated.
Adds example for use of multi-instrument callbacks.