Refine MetricProvider.ForceFlush and define ForceFlush for periodic exporting MetricReader #3563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
changed the title
jsuereth
approved these changes
Jun 23, 2023
reyang
reviewed
Jun 23, 2023
arminru
added
area:sdk
jmacd
approved these changes
Jun 27, 2023
pellared
changed the title
pellared
changed the title
pellared
changed the title
pellared
changed the title
reyang
reviewed
Jun 28, 2023
MrAlias
reviewed
Jun 28, 2023
|
Reopened per #3609 (comment). I updated the PR, based on the feedback I got so far. I added a comment here: #1432 (comment). I do not think that this PR conflicts with #1432. |
pellared
changed the title
ForceFlush for periodic exporting MetricReader
pellared
changed the title
ForceFlush for periodic exporting MetricReader
MrAlias
approved these changes
Aug 3, 2023
jack-berg
approved these changes
Aug 4, 2023
brettmc
reviewed
Aug 8, 2023
dashpole
approved these changes
Aug 8, 2023
jmacd
approved these changes
Aug 8, 2023
jsuereth
approved these changes
Aug 8, 2023
reyang
approved these changes
Aug 8, 2023
brettmc
added a commit
to brettmc/opentelemetry-php
that referenced
this pull request
Aug 9, 2023
open-telemetry/opentelemetry-specification#3563 clarifies the behaviour of forceFlush with push/non-push metric exporters. Break forceFlush out into a PushMetricExporterInterface, and update ExportingReader to only collect/flush if exporter is a push metric exporter.
brettmc
added a commit
to open-telemetry/opentelemetry-php
that referenced
this pull request
Aug 9, 2023
open-telemetry/opentelemetry-specification#3563 clarifies the behaviour of forceFlush with push/non-push metric exporters. Break forceFlush out into a PushMetricExporterInterface, and update ExportingReader to only collect/flush if exporter is a push metric exporter.
otel-php-bot
pushed a commit
to opentelemetry-php/exporter-otlp
that referenced
this pull request
Aug 9, 2023
open-telemetry/opentelemetry-specification#3563 clarifies the behaviour of forceFlush with push/non-push metric exporters. Break forceFlush out into a PushMetricExporterInterface, and update ExportingReader to only collect/flush if exporter is a push metric exporter.
otel-php-bot
pushed a commit
to opentelemetry-php/sdk
that referenced
this pull request
Aug 9, 2023
open-telemetry/opentelemetry-specification#3563 clarifies the behaviour of forceFlush with push/non-push metric exporters. Break forceFlush out into a PushMetricExporterInterface, and update ExportingReader to only collect/flush if exporter is a push metric exporter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like we have forgotten to define
ForceFlushfor metric readers. Take notice that the spec currently references it here:opentelemetry-specification/specification/metrics/sdk.md
Lines 173 to 175 in c07f4a2
This PR is intended to make the specification around metric's
ForceFlushclearer and more normative.The proposal does not require each
MetricReaderto implementForceFlush(because it not needed for pull-based exporters) This is intended to support the following: