howto configure exporter programmatically in spring starter #4282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
Apr 11, 2024
| import io.opentelemetry.api.metrics.MeterProvider; | ||
| import io.opentelemetry.exporter.otlp.http.trace.OtlpHttpSpanExporter; | ||
| import io.opentelemetry.exporter.otlp.http.trace.OtlpHttpSpanExporterBuilder; | ||
| import io.opentelemetry.exporter.otlp.internal.OtlpConfigUtil; |
There was a problem hiding this comment.
is there a way to avoid using internal classes?
There was a problem hiding this comment.
Only if we implement open-telemetry/opentelemetry-java#6368
There was a problem hiding this comment.
BTW, the same class is added in open-telemetry/opentelemetry-java-examples#378
I'm planning to use an "include" mechanism: #4276
There was a problem hiding this comment.
is there a way to avoid using internal classes?
done 😄
theletterf
approved these changes
Apr 12, 2024
Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
zeitlinger
force-pushed
the
spring-exporter
branch
from
d26fa4a
to
92d822c
Compare
cartermp
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on open-telemetry/opentelemetry-java-examples#394