Rename "labels" to "attributes" OTEP 0152 #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes open-telemetry/opentelemetry-specification#1989 OTEP 0152 predates renaming of labels to attributes in the spec. Unfortunately the schema file format still uses the term "label" in the metrics section this way: ```yaml metrics: changes: - rename_labels: label_map: # map of key/values. The keys are the old label name used # in the previous version, the values are the new label name # starting from this version. apply_to_metrics: # Optional. If it is missing the transformation is applied # to all metrics. If it is present the transformation is applied # only to the metrics with the name that is found in the sequence # specified below. ``` We don't want the word `label` in the schema files, instead we want the word `attribute` to be used instead. Discussed in spec meeting, decided: - OTEPs which are not part of the spec repo are not considered to be final, or be an actual part of stable spec (OTEPs are not labeled "stable" in any way). - Modify the OTEP, rename `label` to `attribute` (this commit). - Merge the OTEP with the spec.
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-go
that referenced
this pull request
Oct 5, 2021
carlosalberto
approved these changes
Oct 5, 2021
iNikem
approved these changes
Oct 6, 2021
|
@open-telemetry/specs-metrics-approvers @open-telemetry/specs-approvers please review. |
|
I need 2 more approvals, please. |
arminru
approved these changes
Oct 7, 2021
|
open-telemetry/opentelemetry-go#2267 is blocked on this. |
jmacd
approved these changes
Oct 7, 2021
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-go
that referenced
this pull request
Oct 8, 2021
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-go
that referenced
this pull request
Oct 12, 2021
MrAlias
added a commit
to open-telemetry/opentelemetry-go
that referenced
this pull request
Oct 15, 2021
* Add ability to parse Schema files according to OTEP 0152 The parser and parsed representation (AST) are placed in a separate Go module so that they are can be consumed independently without the need to bring the rest of the SDK. Ability to use the parsed representation for schema conversions can be added later. * Fixes based on PR comments * Rename "label" to "attributes" See open-telemetry/oteps#181 * Fixes based on PR comments * Add README.md * Wrap the error in Parse() * Add docs for exporter types * Use yaml.NewDecoder * Verify parsed content in the test * Fix indentation in README example * Fix README spaces vs tabs * Correctly space imports * Add heading to README Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
shbieng
added a commit
to shbieng/opentelemetry-go
that referenced
this pull request
Aug 26, 2022
* Add ability to parse Schema files according to OTEP 0152 The parser and parsed representation (AST) are placed in a separate Go module so that they are can be consumed independently without the need to bring the rest of the SDK. Ability to use the parsed representation for schema conversions can be added later. * Fixes based on PR comments * Rename "label" to "attributes" See open-telemetry/oteps#181 * Fixes based on PR comments * Add README.md * Wrap the error in Parse() * Add docs for exporter types * Use yaml.NewDecoder * Verify parsed content in the test * Fix indentation in README example * Fix README spaces vs tabs * Correctly space imports * Add heading to README Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-telemetry/opentelemetry-specification#1989
OTEP 0152 predates renaming of labels to attributes in the spec. Unfortunately
the schema file format still uses the term "label" in the metrics section this way:
We don't want the word
labelin the schema files, instead we want the wordattributeto be used instead.Discussed in spec meeting, decided:
or be an actual part of stable spec (OTEPs are not labeled "stable" in any way).
labeltoattribute(this commit).