Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getScopedElementsTemplate to publish #2707

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RoXuS
Copy link

@RoXuS RoXuS commented Sep 27, 2023

What I did

Added getScopedElementsTemplate to publish to use it with litFixtureSync function.

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2023

⚠️ No Changeset found

Latest commit: a7076a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Westbrook
Copy link
Contributor

Can you please share some extended usage of this so I can understand what this is unlocking?

@RoXuS
Copy link
Author

RoXuS commented Sep 27, 2023

Of course, if we use fixtureSync with scoped elements like this:

    const el = fixtureSync<DtContractHeader>(fixtureData, {
      scopedElements: {
        'dt-contract-header': DtContractHeader,
      },
    });

Then we have this error:
image

fixtureSync call litFixtureSync without getScopedElementsTemplate.

export function litFixtureSync(template, options = {}, getScopedElementsTemplate) {
...

@jamiejojo
Copy link

jamiejojo commented Sep 27, 2023 via email

@Westbrook Westbrook force-pushed the addExportOfGetScopedElementsTemplate branch from 4a03030 to a7076a9 Compare October 6, 2023 17:58
@Westbrook
Copy link
Contributor

There are a bunch of tests that fail with this change. Please take a closer look so we can fully review this update.

See: https://github.com/open-wc/open-wc/actions/runs/6434919239/job/17475126467?pr=2707

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants