Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document for SVC API #1039

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

starwarfan
Copy link
Collaborator

No description provided.

@@ -452,6 +454,10 @@ A publication can send either media or data, but a QUIC *transport* channel can
mid: string(MID),
from: string(TrackID) | string(StreamID),
parameters: object(VideoParametersSpecification) | undefined,
preferredLayers: { // Used to force layers for SVC stream
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we move this to parameters above? And the same shall be shared by subscription control singaling.

Copy link
Collaborator Author

@starwarfan starwarfan Jul 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My consideration is that the preferredLayers may have conflict with parameters.resolution or parameters.framerate. For example, spatial layer 0 and resolution 720p may not align. Placing it outside parameters can mean that it will override parameters.
Besides, I have no idea about describing the parameters of an SVC stream yet. Because an SVC stream may have multiple resolutions. I'll use highest layers for parameters so far.

@@ -131,6 +131,7 @@ Data Model:<br>
transcoding: object(Transcoding), // the transcoding control
notifying: object(Notifying), // notification control
selectActiveAudio: boolean, // select 3 most active audio streams for the room
senderBandwidthEstimation: boolean, // enable send side bandwidth estimation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be part of webrtc agent configuration instead of room configuration.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion, ok to put this as part of room configuration.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change its name to webrtcSenderSideBandwidthEstimation? This configuration doesn't work for WebTransport connections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants