fix grpc missing host #1353
Open
fix grpc missing host #1353
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enable grpc, owt always use default cluster host even I config the cluster.host according document.
This pr fix it.
By the way, according document, to enable grpc, we should add host.cluster to components except cluster-manager. But according to the source code, cluster.grpc_host is required, too. Is any difference between cluster.host and cluster.grpc_host?
Originally, I planned to add cluster.host to all the places where cluster.grpc host is used, but compiling an image takes 1 hour, which is too troublesome. Finally, I decided to add both cluster.grpc host and cluster.host to the configuration