-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setMaxResolution for adaptive video #699
base: master
Are you sure you want to change the base?
Conversation
@@ -176,6 +176,26 @@ void VideoTranscoder::forceKeyFrame(const v8::FunctionCallbackInfo<v8::Value>& a | |||
me->forceKeyFrame(outStreamID); | |||
} | |||
|
|||
void VideoTranscoder::setMaxResolution(const v8::FunctionCallbackInfo<v8::Value>& args){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is not registered in node layer through "init" function in line 24. Who will call this function?
This works for me. Maybe I made a crooked patch, I'm not good at GIT. Try adding all the wrappers yourself. I think this patch is useful. It's simple |
@@ -1,4 +1,4 @@ | |||
Apache License | |||
Apache License!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why adding this change to license and readme file?
@@ -93,7 +93,7 @@ function calculateSignature (toSign, key) { | |||
function ManagementApi (spec) { | |||
this.id = spec.id; | |||
this.key = spec.key; | |||
this.url = spec.url || '/'; | |||
this.url = spec.url || window.location.pathname.replace(/\/console.*/g, "/"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code conflict with latest master code
For adaptive video, you need to limit the transcoded resolution. I needed this to limit the output bndwidth for rtmp (i use streaming-out) and probably to reduce the load on the processor
Usage:
owt-server/source/agent/video/index.js
Line 277 in 5fc8bf2
Please see my question
#698