Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed terminal not restored after quit issue #529

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

nanjj
Copy link
Contributor

@nanjj nanjj commented Mar 8, 2024

What problem does this PR solve?

Issue Number: ref [c-bata/go-prompt#228]

What is changed and how it works?

The patch workaround issue [c-bata/go-prompt#228], make the terminal running ts-cli works correctly after quit, exit, ControlC or ControlD.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Run ts-cli on linux, end with exit or quit, watch the terminal normal or not
  • Run ts-cli on linux, end with Ctrl+c or Ctrl + d, watch the terminal is normal or not

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@xiangyu5632
Copy link
Member

xiangyu5632 commented Mar 9, 2024

pls alert the commit message following the Conventional Commits
anyway, someone's feedback has the same problem with Linux, and can you also fix issue #519?

@nanjj
Copy link
Contributor Author

nanjj commented Mar 12, 2024

pls alert the commit message following the Conventional Commits anyway, someone's feedback has the same problem with Linux, and can you also fix issue #519?

  1. Done the conventional message,
  2. I can not reproduce it under tmux issue ts-cli commnad line text often corrupt when moving the caret in a histroy command #519.

@xiangyu5632
Copy link
Member

xiangyu5632 commented Mar 12, 2024

pls alert the commit message following the Conventional Commits anyway, someone's feedback has the same problem with Linux, and can you also fix issue #519?

  1. Done the conventional message,

problem also exits
you can use the following command to commit again

git commit -s -m "chore: xxx"

or

git commit --amend

commit message needs to add a "chore" or "fix" ahead

The patch workaround issue [c-bata/go-prompt#228], make the terminal running
ts-cli works correctly after quit, exit, ControlC or ControlD.

Signed-off-by: JUN JIE NAN <nanjunjie@gmail.com>
@nanjj
Copy link
Contributor Author

nanjj commented Mar 20, 2024

pls alert the commit message following the Conventional Commits anyway, someone's feedback has the same problem with Linux, and can you also fix issue #519?

  1. Done the conventional message,

problem also exits you can use the following command to commit again

git commit -s -m "chore: xxx"

or

git commit --amend

commit message needs to add a "chore" or "fix" ahead

done

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 74.75%. Comparing base (e8f316b) to head (db29267).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #529      +/-   ##
==========================================
- Coverage   74.81%   74.75%   -0.06%     
==========================================
  Files         550      550              
  Lines      117481   117494      +13     
==========================================
- Hits        87889    87837      -52     
- Misses      24203    24254      +51     
- Partials     5389     5403      +14     

@xiangyu5632 xiangyu5632 merged commit 32722eb into openGemini:main Mar 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants