fix(deps): update dependency moment to v2.29.4 [security]

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
moment (source)	2.27.0 -> 2.29.4

GitHub Vulnerability Alerts

CVE-2022-24785

Impact

This vulnerability impacts npm (server) users of moment.js, especially if user provided locale string, eg fr is directly used to switch moment locale.

Patches

This problem is patched in 2.29.2, and the patch can be applied to all affected versions (from 1.0.1 up until 2.29.1, inclusive).

Workarounds

Sanitize user-provided locale name before passing it to moment.js.

References

Are there any links users can visit to find out more?

For more information

If you have any questions or comments about this advisory:

• Open an issue in moment repo

CVE-2022-31129

Impact

• using string-to-date parsing in moment (more specifically rfc2822 parsing, which is tried by default) has quadratic (N^2) complexity on specific inputs
• noticeable slowdown is observed with inputs above 10k characters
• users who pass user-provided strings without sanity length checks to moment constructor are vulnerable to (Re)DoS attacks

Patches

The problem is patched in 2.29.4, the patch can be applied to all affected versions with minimal tweaking.

Workarounds

In general, given the proliferation of ReDoS attacks, it makes sense to limit the length of the user input to something sane, like 200 characters or less. I haven't seen legitimate cases of date-time strings longer than that, so all moment users who do pass a user-originating string to constructor are encouraged to apply such a rudimentary filter, that would help with this but also most future ReDoS vulnerabilities.

References

There is an excellent writeup of the issue here: https://github.com/moment/moment/pull/6015#issuecomment-1152961973=

Details

The issue is rooted in the code that removes legacy comments (stuff inside parenthesis) from strings during rfc2822 parsing. moment("(".repeat(500000)) will take a few minutes to process, which is unacceptable.

---

Release Notes

moment/moment (moment)

v2.29.4

Compare Source

• Release Jul 6, 2022
  • #​6015 [bugfix] Fix ReDoS in preprocessRFC2822 regex

v2.29.3

Compare Source

• Release Apr 17, 2022
  • #​5995 [bugfix] Remove const usage
  • #​5990 misc: fix advisory link

v2.29.2

Compare Source

• Release Apr 3 2022

Address GHSA-8hfj-j24r-96c4

v2.29.1

Compare Source

• Release Oct 6, 2020

Updated deprecation message, bugfix in hi locale

v2.29.0

Compare Source

• Release Sept 22, 2020

New locales (es-mx, bn-bd).
Minor bugfixes and locale improvements.
More tests.
Moment is in maintenance mode. Read more at this link:
https://momentjs.com/docs/#/-project-status/

v2.28.0

Compare Source

• Release Sept 13, 2020

Fix bug where .format() modifies original instance, and locale updates

---

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Mend Renovate. View repository job log here.

[renovate]

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

• any of the package files in this branch needs updating, or
• the branch becomes conflicted, or
• you click the rebase/retry checkbox if found above, or
• you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @ngrx/core@1.2.0
npm ERR! Found: rxjs@6.5.4
npm ERR! node_modules/rxjs
npm ERR!   rxjs@"6.5.4" from the root project
npm ERR!   rxjs@"6.5.4" from @angular-devkit/schematics@9.1.7
npm ERR!   node_modules/@angular-devkit/schematics
npm ERR!     @angular-devkit/schematics@"9.1.7" from @angular/cli@9.1.7
npm ERR!     node_modules/@angular/cli
npm ERR!       dev @angular/cli@"^9.0.4" from the root project
npm ERR!     @angular-devkit/schematics@"9.1.7" from @schematics/angular@9.1.7
npm ERR!     node_modules/@schematics/angular
npm ERR!       @schematics/angular@"9.1.7" from @angular/cli@9.1.7
npm ERR!       node_modules/@angular/cli
npm ERR!         dev @angular/cli@"^9.0.4" from the root project
npm ERR!     1 more (@schematics/update)
npm ERR!   20 more (@angular-devkit/core, @angular-devkit/architect, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer rxjs@"^5.0.0-beta.12" from @ngrx/core@1.2.0
npm ERR! node_modules/@ngrx/core
npm ERR!   @ngrx/core@"^1.2.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: rxjs@5.5.12
npm ERR! node_modules/rxjs
npm ERR!   peer rxjs@"^5.0.0-beta.12" from @ngrx/core@1.2.0
npm ERR!   node_modules/@ngrx/core
npm ERR!     @ngrx/core@"^1.2.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /tmp/renovate-cache/others/npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/renovate-cache/others/npm/_logs/2023-03-11T03_51_11_172Z-debug-0.log