Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Update node dependencies #319

Merged
merged 1 commit into from
Nov 21, 2022
Merged

[web] Update node dependencies #319

merged 1 commit into from
Nov 21, 2022

Conversation

dgdavid
Copy link
Contributor

@dgdavid dgdavid commented Nov 18, 2022

Let's keep dependencies up-to-date

Please, note that npm audit still complaining about a 2 critical severity vulnerabilities because of surge depending on a vulnerable version of minimist. See sintaxi/surge#473

Fixing it via npm audit fix --force ends up in an important step backward with 18 vulnerabilities (8 moderate, 8 high, 2 critical)

Another note is that a warning about TypeScript version might be shown

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <4.9.0

YOUR TYPESCRIPT VERSION: 4.9.3

Please only submit bug reports when using the officially supported version.

Other than that, I feel we should go ahead updating dependencies if CI is fine.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.674% when pulling e3b9209 on update-node-packages into b044a44 on master.

@dgdavid dgdavid merged commit 16469fc into master Nov 21, 2022
@dgdavid dgdavid deleted the update-node-packages branch November 21, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants