Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Alpine County, CA #7189

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Update Alpine County, CA #7189

wants to merge 6 commits into from

Conversation

arch0345
Copy link
Contributor

No description provided.

Copy link

Source Result Output
sources/us/ca/alpine.json/addresses/county ❌ No features Image / Map / Log
sources/us/ca/alpine.json/parcels/county ✅ 3,051 features Image / Map / Log

Copy link

Source Result Output
sources/us/ca/alpine.json/addresses/county ❌ No features Image / Map / Log
sources/us/ca/alpine.json/parcels/county ✅ 3,051 features Image / Map / Log

Copy link

Source Result Output
sources/us/ca/alpine.json/addresses/county ❌ No features Image / Map / Log
sources/us/ca/alpine.json/parcels/county ✅ 3,051 features Image / Map / Log

@data-please
Copy link

data-please bot commented Apr 30, 2024

Copy link

Source Result Output
sources/us/ca/alpine.json/addresses/county ✅ 3,051 features Image / Map / Log
sources/us/ca/alpine.json/parcels/county ✅ 3,051 features Image / Map / Log

@data-please
Copy link

data-please bot commented Apr 30, 2024

Copy link

Source Result Output
sources/us/ca/alpine.json/addresses/county ❌ No features Image / Map / Log
sources/us/ca/alpine.json/parcels/county ✅ 3,051 features Image / Map / Log

Copy link

github-actions bot commented May 1, 2024

Source Result Output
sources/us/ca/alpine.json/addresses/county ❌ No features Image / Map / Log
sources/us/ca/alpine.json/parcels/county ✅ 3,051 features Image / Map / Log

@iandees
Copy link
Member

iandees commented May 1, 2024

Looks like there might be a typo in the schema 🤔

@iandees
Copy link
Member

iandees commented May 1, 2024

Ah nope, typo in the source file here. I misread the error from pre-commit. Updated!

Copy link

github-actions bot commented May 1, 2024

Source Result Output
sources/us/ca/alpine.json/addresses/county ✅ 3,051 features Image / Map / Log
sources/us/ca/alpine.json/parcels/county ✅ 3,051 features Image / Map / Log

@data-please
Copy link

data-please bot commented May 1, 2024

Copy link

github-actions bot commented May 1, 2024

Source Result Output
sources/us/ca/alpine.json/addresses/county ✅ 3,051 features Image / Map / Log
sources/us/ca/alpine.json/parcels/county ✅ 3,051 features Image / Map / Log

@data-please
Copy link

data-please bot commented May 1, 2024

Copy link

github-actions bot commented May 1, 2024

Source Result Output
sources/us/ca/alpine.json/addresses/county ✅ 3,051 features Image / Map / Log
sources/us/ca/alpine.json/parcels/county ✅ 3,051 features Image / Map / Log

@data-please
Copy link

data-please bot commented May 1, 2024

Copy link

github-actions bot commented May 1, 2024

Source Result Output
sources/us/ca/alpine.json/addresses/county ✅ 3,051 features Image / Map / Log
sources/us/ca/alpine.json/parcels/county ✅ 3,051 features Image / Map / Log

@data-please
Copy link

data-please bot commented May 1, 2024

Copy link

github-actions bot commented May 1, 2024

Source Result Output
sources/us/ca/alpine.json/addresses/county ✅ 3,051 features Image / Map / Log
sources/us/ca/alpine.json/parcels/county ✅ 3,051 features Image / Map / Log

@data-please
Copy link

data-please bot commented May 1, 2024

@arch0345
Copy link
Contributor Author

arch0345 commented May 1, 2024

Looks like it's outputting the full field for postcode for addresses points that don't have one, this doesn't seem to be an issue with unit

@iandees
Copy link
Member

iandees commented May 2, 2024

The regexp function uses this code here. I wonder if re.sub() has a different behavior when the pattern doesn't match at all 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants