class Alpr: Set self.loaded to False before exception #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are currently [46 open issues related to `loaded`](https://github.com/openalpr/openalpr/search?p=2&q=loaded&type=issues). Many of these [`AttributeError` issues](https://github.com/openalpr/openalpr/search?q=AttributeError&type=issues) are caused because `self.loaded` is only defined at the end of this method on (line 117). If an exception is raised (like line 62, etc.) then `self.loaded` is _never_ defined so subsequent code fails when trying to determine if `Alpr` has successfully loaded. Closes openalpr#311 Closes openalpr#414 Closes openalpr#426 Closes openalpr#461 Closes openalpr#508 Closes openalpr#533 Closes openalpr#660 Closes openalpr#732 Closes openalpr#738 Closes openalpr#764 Closes openalpr#806 Closes openalpr#837 Closes openalpr#913 Closes openalpr#916 Related to openalpr#555 Related to Homebrew/homebrew-core#89948
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an exception is raised (like line 62, etc.) then
self.loadedis never defined so subsequent code fails when trying to determine ifAlprhas successfully loaded. There are currently 46 open issues related toloaded. Many of these areAttributeErrorissues caused becauseself.loadedis only defined at the end of this method on (line 117).Closes #311
Closes #414
Closes #426
Closes #461
Closes #508
Closes #533
Closes #660
Closes #732
Closes #738
Closes #764
Closes #806
Closes #837
Closes #913
Closes #916
Related to #555
Related to Homebrew/homebrew-core#89948
https://groups.google.com/g/openalpr/search?q=AttributeError
@matthill Your review, please.