Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spindle-tokens): update design tokens #965

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

"attributes": {
"category": "color"
},
"value": "{Color.Primitive.Third Party.X Bkack.value}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BlackがBkackになっているようです

Comment on lines +533 to +538
"Instagram Pink": {
"attributes": {
"category": "color"
},
"value": "{Color.Primitive.Third Party.Instagram White.value}"
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instagram PinkにInstagram Whiteが割り当てられているようです

Comment on lines +516 to +521
"Instagram White": {
"attributes": {
"category": "color"
},
"value": "{Color.Primitive.Third Party.Instagram White.value}"
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PrimitiveにInstagram Whiteが存在しないようです

@YusukeMoriJapan
Copy link

@herablog
Androidアプリ開発の実装でいくつか気付いた点があったので、コメントだけ残しておきました🙏

@herablog
Copy link
Member

herablog commented May 15, 2024

@herablog Androidアプリ開発の実装でいくつか気付いた点があったので、コメントだけ残しておきました🙏

@YusukeMoriJapan ありがとうございます、大変助かります 🙏 近々、元データをFigmaのVariablesに変更する予定でそちらもまたアナウンスさせてください〜

@MasatoHonda 一旦上記確認お願いしやす!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants