Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A set of UI watchers to settle common Android permission dialog and alike #547

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

liaoshengyou
Copy link

liaoshengyou edit watcher

@mingyuan-xia
Copy link
Member

用硬编码字符串的方式查找权限弹框没有普遍性,框架本身不考虑吸收这类方案,不过可以考虑放到ext下面作为一个plugin,而且如果要merge需要这个硬编码列表可以二次配置,否则几个安卓版本后这个脚本没有维护基本就没用了

@mingyuan-xia mingyuan-xia changed the title U2 watcher A set of UI watchers to settle common Android permission dialog and alike May 25, 2020
@codeskyblue
Copy link
Member

不好意思,刚看到这个PR,内容还是很不错的。我找个时间手工merge一下

@codeskyblue
Copy link
Member

用硬编码字符串的方式查找权限弹框没有普遍性,框架本身不考虑吸收这类方案,不过可以考虑放到ext下面作为一个plugin,而且如果要merge需要这个硬编码列表可以二次配置,否则几个安卓版本后这个脚本没有维护基本就没用了

虽然说硬编码不好,但是至少可以解决眼前的问题

@Rollbar-testing
Copy link

Checked

@codeskyblue
Copy link
Member

暂时先保留这个PR,当做参考。不打算Merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants