Fix(HostDashboardReports): Include children in host balance #10169
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @gustavlrsn and the rest of your teammates on |
gustavlrsn
force-pushed
the
03-11-Fix_HostDashboardReports_Include_children_in_host_balance
branch
from
5f3fe08
to
a0d5a99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As opencollective/opencollective-api#9906 changes the totalMoneyManaged stats resolver to include the host children balance, we should include children when getting the host balance in HostDashboardReports.
This will update the host balance to be correct (including host events/projects), and maintain the (correct) number for "hosted collectives" balance, that is computed in the frontend as
totalMoneyManaged - hostBalance