Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix help&support page responsiveniss solves issue #7268 #10266

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MarwanBz
Copy link

@MarwanBz MarwanBz commented Apr 8, 2024

Resolve [https://github.com/opencollective/opencollective/issues/7268]

Description

this fixes the raised issue about the responsiveness help&support page on approximately 850px or less devices

Screenshots

chrome-capture-2024-4-8 (1)

Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencollective-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2024 8:52am
opencollective-styleguide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2024 8:52am

Copy link
Member

@Betree Betree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MarwanBz, thanks for your contribution! Some feedback below.

  • The "Get to Know Us" still has truncated text on some resolutions
    image

  • There is a regression on widescreen, the topics are overlapping each other because the width is too narrow
    image

Comment on lines +114 to +115
width={['100%', '568px','750px', '864px', null, null, '1020px']}
gridTemplateColumns={[null, 'repeat(2, 288px)', 'repeat(2, 300px)','repeat(3, 272px)', null, `repeat(3, 320px)`]}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only support 4 breakpoints. So only the 4 first values will be considered. The 1020px in there was already unnecessary, but with the addition of 750px we're not considering null anymore, which disabled the fixed width and is likely the root cause for the missing gap reported above.

@MarwanBz
Copy link
Author

thanks for the feedback @Betree!
I really appreciate you taking the time to review my code, and
I'll make the changes you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants