Fix some lint warnings about useMemo #10280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Betree
reviewed
Apr 11, 2024
Comment on lines
-344
to
-345
| const budgetItemsParams = [transactions, expenses, filter]; | ||
| const allItems = React.useMemo(() => getBudgetItems(...budgetItemsParams), budgetItemsParams); |
There was a problem hiding this comment.
Too bad that linter doesn't get this, it's a nice syntactic sugar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not an exhaustive fix for this class of lint error, but its a start.
The
useMemochanges here are relatively safe wrt to side effects, but please take a look if anything stands out.I might do
useCallbacknext.I attempted to tackle
useEffectwarnings, but this is a bigger issue, as just adding variables to the dep list to satisfy the linter could affect behavior in subtle ways. In many cases we are falling into an anti-pattern (see https://react.dev/learn/you-might-not-need-an-effect#how-to-remove-unnecessary-effects) and we should adopt another solution.