Contributions drawer in dashboard #10315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hdiniz
force-pushed
the
contributions-drawer
branch
from
731cdd9
to
6c93ad7
Compare
kewitz
reviewed
May 13, 2024
| * @typedef {{ target?: string, href?: string | Record<string, any>, animate?: any, className?: string, title?: string, onClick?: () => void, openInNewTab?: boolean, className?: string, children?: any, 'data-cy'?: string } & React.HTMLAnchorElement} LinkProps | ||
| * @type React.ForwardRefRenderFunction<HTMLAnchorElement, LinkProps> | ||
| */ | ||
| export default React.forwardRef((props, ref) => <Link innerRef={ref} {...props} />); |
There was a problem hiding this comment.
Why implement innerRef and not use the default forwardRef param in the base component?
There was a problem hiding this comment.
Can you give me an example of what you mean? If you are refering to the name of the variable, the linter complains if I call it ref
There was a problem hiding this comment.
I meant implementing forwardRef in the component itself and not like a wrapper.
hdiniz
force-pushed
the
contributions-drawer
branch
from
b1b2076
to
c40f801
Compare
hdiniz
force-pushed
the
contributions-drawer
branch
from
92794ab
to
445269d
Compare
kewitz
approved these changes
May 21, 2024
Co-authored-by: Leo Kewitz <leo@opencollective.com>
Co-authored-by: Leo Kewitz <leo@opencollective.com>
Co-authored-by: Leo Kewitz <leo@opencollective.com>
hdiniz
force-pushed
the
contributions-drawer
branch
from
851ec3e
to
d53ad28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related opencollective/opencollective#7345
Description
Adds a preview feature of the new contribution management in dashboard. A rough draft of the contribution drawer details, previous charges and timeline.
Screenshots