Add banner opencollective.com/$slug/financial-contributors.svg

[mkurz]

Following this route entry:

opencollective-images/src/server/routes.js

Line 72 in f2ca296

app.get('/:collectiveSlug/:backerType.svg', controllers.banner);

the controller method will render users by fetching them from the api:

opencollective-images/src/server/controllers/banner.js

Line 39 in f2ca296

users = await fetchMembersWithCache(req.params);

In the fetchMembers method the backerType param will be handled if its value is contributors:

opencollective-images/src/server/lib/graphql.js

Line 185 in f2ca296

if (backerType === 'contributors') {

or if its value is sponsor[s], organization[s] or individual[s] and backer[s] (which the else branch does not check for these two values, so I guess there is some other routing/proxy going on before opencollective-images processes the url?)

opencollective-images/src/server/lib/graphql.js

Lines 204 to 209 in f2ca296

	} else if (backerType) {
	if (backerType.match(/sponsor/i) || backerType.match(/organization/i)) {
	type = 'ORGANIZATION,COLLECTIVE';
	} else {
	type = 'USER';
	}

Now that allows us to build following urls:

These 4 generate the same svg:

• https://opencollective.com/playframework/individuals.svg
• https://opencollective.com/playframework/individual.svg
• https://opencollective.com/playframework/backers.svg
• https://opencollective.com/playframework/backer.svg

These 4 generate the same svg:

• https://opencollective.com/playframework/organizations.svg
• https://opencollective.com/playframework/organization.svg
• https://opencollective.com/playframework/sponsors.svg
• https://opencollective.com/playframework/sponsor.svg

Finally a svg for contributors:

• https://opencollective.com/playframework/contributors.svg (there is no version without the trailing s, because matching wasn't used)

Now with this pull request we would also have:

• https://opencollective.com/playframework/financial-contributors.svg
• https://opencollective.com/playframework/financial-contributor.svg

which would display all financial contributors, bascially a sum of the above individuals + organizations.

This is bascially the same concept you use in the badge when you render
https://opencollective.com/playframework/all/badge.svg
which renders:

Looking at the badge.js source:

opencollective-images/src/server/controllers/badge.js

Lines 21 to 30 in f2ca296

	if (req.params.backerType.match(/sponsor/i) || req.params.backerType.match(/organization/i)) {
	backerType = 'sponsors';
	label = req.query.label || req.params.backerType;
	} else if (req.params.backerType.match(/backer/i) || req.params.backerType.match(/individual/i)) {
	backerType = 'backers';
	label = req.query.label || req.params.backerType;
	} else {
	backerType = 'all';
	label = req.query.label || 'financial contributors';
	}

where you label all backers as financial contributors by default.
And even more important that's what you do in the graphql query as well, you just fetch "all" "backers" and define them as "financial contributors" in the last else here:

opencollective-images/src/server/lib/graphql.js

Lines 110 to 119 in f2ca296

	if (backerType.match(/sponsor/i) || backerType.match(/organization/i)) {
	count = res.Collective.stats.backers.organizations;
	name = backerType;
	} else if (backerType.match(/backer/i) || backerType.match(/individual/i)) {
	count = res.Collective.stats.backers.users;
	name = backerType;
	} else {
	count = res.Collective.stats.backers.all;
	name = 'financial contributors';
	}

So that's what I do in the pull request as well to render financial-contributor.svg:
I just pass null as type, to fetch all organizations, users, etc. and the role = 'BACKER'; line makes sure they are all backers.

What do you think?
I think it makes sense 😉

[mkurz]

@znarf What do you think?

[smileBeda]

This is still stalling? It would be super useful and fair to show all contributors, not separately, but together!