Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

creating a single client to put folders in cloud #335

Merged
merged 1 commit into from
Jun 4, 2024
Merged

creating a single client to put folders in cloud #335

merged 1 commit into from
Jun 4, 2024
+84 −51

Conversation

ashmeet-kandhari
Copy link

Relates to #1325

Explain the details for making this change. What existing problem does the pull request solve?

  • With large number of files in a folder and uploading them, s3 storage adapter was creating new client for each file and this failed as there were limits to get new s3 client.
  • Fix was to create a single client while putDir operation was called and use the same client to upload files

closes #1325

@ashmeet-kandhari ashmeet-kandhari changed the title creating a single client to put dir in cloud creating a single client to put folders in cloud Mar 8, 2023
@ashmeet-kandhari
Copy link
Author

Hi @ricardo-devis-agullo ,

Any update on this PR?
Might need some help with the failing builds as this is more of node version support than the changes to the code

@ashmeet-kandhari
Copy link
Author

@ricardo-devis-agullo Any updates?

@ricardo-devis-agullo ricardo-devis-agullo merged commit 8436f8c into opencomponents:master Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardo-devis-agullo ricardo-devis-agullo ricardo-devis-agullo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashmeet-kandhari @ricardo-devis-agullo