Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fs-extra in /packages/oc-gs-storage-adapter from 4.0.3 to 5.0.0 #39

Merged
merged 1 commit into from Jan 26, 2018

Conversation

dependencies[bot]
Copy link

@dependencies dependencies bot commented Jan 26, 2018

Dependencies.io has updated fs-extra (a npm dependency in /packages/oc-gs-storage-adapter) from "4.0.3" to "5.0.0".

5.0.0

Significant refactor of copy() & copySync(), including breaking changes. No changes to other functions in this release.

Huge thanks to manidlou for doing most of the work on this release.

  • The filter option can no longer be a RegExp (must be a function). This was deprecated since fs-extra v1.0.0. #512
  • copy()'s filter option can now be a function that returns a Promise. #518
  • copy() & copySync() now use fs.copyFile()/fs.copyFileSync() in environments that support it (currently Node 8.5.0+). Older Node versions still get the old implementation. #505
  • Don't allow copying a directory into itself. #83
  • Handle copying between identical files. #198
  • Error out when copying an empty folder to a path that already exists. #464
  • Don't create dest's parent if the filter function aborts the copy() operation. #517
  • Fix writeStream not being closed if there was an error in copy(). #516

Copy link
Contributor

@nickbalestra nickbalestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just use writeFileSync so this should be safe according to the release note

@codecov-io
Copy link

codecov-io commented Jan 26, 2018

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files           8        8           
  Lines         206      206           
  Branches       33       33           
=======================================
  Hits          198      198           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 006a91f...dd97506. Read the comment docs.

@matteofigus matteofigus merged commit a32e9d9 into master Jan 26, 2018
@matteofigus matteofigus deleted the fs-extra-5.0.0-73.2.0 branch January 26, 2018 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants