Pipelines update for FFmpeg 5 and security fixes #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmorkalov
force-pushed
the
as/pipelines_update_4.7
branch
from
67642cb
to
b5b1da3
Compare
alalek
approved these changes
Dec 8, 2022
asmorkalov
force-pushed
the
as/pipelines_update_4.7
branch
from
2ff1528
to
d780d93
Compare
asenyaev
reviewed
Dec 13, 2022
| perl -wpe 'BEGIN {our ($found_blank, $bottle_block);} | ||
| if (/(^class )(FfmpegAT4)(\s.*)/) {$_=$1."FfmpegOpencv".$3."\n"; next;} |
There was a problem hiding this comment.
You can leave FfmpegOpencv here, because the previous logic was something like $2.Opencv what meant FfmpegOpencv, but wasn’t obvious. Or move back $2.
link to the previous logic (before my changes), notice $2: 602a8be#diff-7d5a84b3617f8aff01b2fc673bb198946e3632d90592fd61d3e3e24ddd6dbf70L74
There was a problem hiding this comment.
Yes, it works, tried in my fork.
Log: https://github.com/opencv/opencv-python/actions/runs/3694906850/jobs/6256653970
|
Requires opencv/opencv#22965 for the latest numpy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.