add aggregator role for admin and editor #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astefanutti
approved these changes
Jan 26, 2024
KPostOffice
force-pushed
the
rhoaieng-2184
branch
2 times, most recently
from
6f44880
to
f13e4f5
Compare
astefanutti
reviewed
Jan 26, 2024
| - rayjobs/status | ||
| - rayjobs/finalizers | ||
| - rayclusters | ||
| - rayclusters/status |
There was a problem hiding this comment.
It's better to have the sub resources grouped in another item as some of the verbs like deletecollection do not apply.
KPostOffice
force-pushed
the
rhoaieng-2184
branch
from
f13e4f5
to
8c4e834
Compare
Signed-off-by: Kevin <kpostlet@redhat.com>
KPostOffice
force-pushed
the
rhoaieng-2184
branch
from
8c4e834
to
826f7c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
user admin and editors dont have permissions for creating kuberay CRs by default. This will add a role which is automatically aggregated to users with these permissions in their namespaces.
Related issue number
https://issues.redhat.com/browse/RHOAIENG-2184
Checks