chore(ci): Bump GitHub Action workflows to latest major versions #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>
adamdmharvey
changed the title
|
The build workflow went clean. It seems to have removed some of the Node version warnings, so that helps a bit with maintenance. Now just the Ruby one left. 
|
|
For whomever may merge this, a trigger of the deploy should be watched just to make sure it doesn't cause any side effects, but based on my reading of the changelogs for these actions, I believe it should go clean! |
|
Looks good to me. Opened timwis/jkan#283 to track getting this upstream. |
BryanQuigley
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some spring cleaning 馃Ч .
I noticed in the CI output that GitHub Actions was warning about an older version of Node v16 being used which is deprecated. I believe this is due to some of the GH-provided actions.
This PR bumps the GH provided ones. In particular, to use upload-artifact v3 you must also use deploy v4 based on how the upload/download was changed. There's another breaking change in there re: file modes, but looking at the CI output this workflow is not affected by that.
I've left the pinned Ruby action for now for future maintenance.
This also gets many bug fixes, and suggests the artifact workflow is significantly faster (even though CI runs pretty quickly here anyway).