Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Bump Ruby action to remove legacy Node 16 dependency #140

Merged

Conversation

adamdmharvey
Copy link
Contributor

The Actions pipeline currently still has a remaining warning about Node 16 deprecation:

image

It's currently at v1.155 from Oct 2023; this bumps it just to a version in Nov 2023 which includes the bump to Node 20 (and a patch to fix a slowdown found in Node 20) as an incremental improvement. Opted not to entirely jump to the newest as the project likely doesn't need those newest Ruby inclusions (yet).

https://github.com/ruby/setup-ruby/releases/tag/v1.160.0

Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>
@adamdmharvey
Copy link
Contributor Author

Confirmed in Action; build run here no longer shows the warning.

@adamdmharvey adamdmharvey marked this pull request as ready for review March 19, 2024 17:17
Copy link
Member

@BryanQuigley BryanQuigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@BryanQuigley BryanQuigley merged commit 5ab3c15 into opendataphilly:main Mar 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants